Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[integrations/integrations] add integrations to cms pages #2059

Merged
merged 7 commits into from
Nov 17, 2022

Conversation

sarah11918
Copy link
Member

  • New or updated content

This moves relevant content out of integrations/integrations hidden page an onto the appropriate CMS guides

@netlify
Copy link

netlify bot commented Nov 16, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 0672a4b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63762154690fcd00096d4329
😎 Deploy Preview https://deploy-preview-2059--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Nov 16, 2022
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! Do we want to actually start removing this content from integrations/integrations too? So it starts to drop in terms of SEO and these pages float up?

Comment on lines 18 to 23
## Production Sites

The following sites use Astro + Netlify CMS in production:

- [Public Transport Forum New Zealand](https://publictransportforum.nz/articles)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t seem to find the source repo for this site. I’m not against including production examples, but without source code to check how something was done, I’m not sure they offer that much value.

Suggested change
## Production Sites
The following sites use Astro + Netlify CMS in production:
- [Public Transport Forum New Zealand](https://publictransportforum.nz/articles)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... this is @zadeviggers -- ZV, I don't see the source code public on your GH site. Is it available somewhere?

I wonder whether a site without source code valuable to have as proof/SEO? I guess that's a call we have to make!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@zadeviggers zadeviggers Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... this is @zadeviggers -- ZV, I don't see the source code public on your GH site. Is it available somewhere?

Unfortunately, it's not open-source sorry - it's a client project (that I continue to hack on for fun), and I'm not allowed to publish the source.

If you decide to keep it in the list (of course, I completely understand if you remove it), the site now also heavily uses @astrojs/image to optimise images and normalise the formats they're served in, which is the secret to its legendary score on the hyperdrive.

src/pages/en/guides/cms/wordpress.md Outdated Show resolved Hide resolved
@kevinzunigacuellar
Copy link
Member

kevinzunigacuellar commented Nov 16, 2022

I am not sure if this would help anyone but I can add the links for both ssr/ssg code and deployments of the blog demo I made while writing the guides.

(Styling needs work 😇)

@sarah11918
Copy link
Member Author

Ooh, @kevinzunigacuellar, if those are the exact Guide/Tutorial repos and demos, then yes! Let's add them, but not in another section like community resources. Sort of like a "wrap up" (or intro? 🤔 ) to the guides themselves.

I'm happy to let you play around with what you think works.

sarah11918 and others added 2 commits November 16, 2022 16:13
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@sarah11918
Copy link
Member Author

Do we want to actually start removing this content from integrations/integrations too?

Sounds like a plan! Done!

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarah11918 sarah11918 merged commit edeb6e2 into main Nov 17, 2022
@sarah11918 sarah11918 deleted the cms-integrations branch November 17, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants