Changes breaking text in congrats-bot.mjs script #1653
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
scripts/congrats-bot.mjs
Outdated
| @@ -9,7 +9,7 @@ setDiscordMessage(COMMIT_AUTHOR, COMMIT_ID, COMMIT_MESSAGE); | |||
| * @param {string} commitMsg A full commit message | |||
| */ | |||
| function setDiscordMessage(author, id, commitMsg) { | |||
| const commitMessage = commitMsg.split('\n').shift().replaceAll('`', ''); | |||
| const commitMessage = commitMsg.split('\n').shift().replaceAll('`', '').replaceAll('--', '––'); | |||
There was a problem hiding this comment.
Interesting. Didn’t think of this approach!
I think we can even go one better:
| const commitMessage = commitMsg.split('\n').shift().replaceAll('`', '').replaceAll('--', '––'); | |
| const commitMessage = commitMsg.split('\n').shift().replaceAll('`', '').replaceAll('--', '--'); |
Very hard to see, but I’ve added a zero-width space between the two hyphens. What do you think?
There was a problem hiding this comment.
Sounds like an even smoother approach! Added it!
The only worry is discord might not read it as a character, but from my test, it seems to.
delucis
added
the
hacktoberfest-accepted
There was a problem hiding this comment.
Thanks! Lucky we have a PR open at the moment that we can test this with when it merges, so I'll get this merged now and we can revisit if there any problems.
Welcome to Team Docs @Lofty-Brambles!
* Escapes breaking text in congrats-bot.mjs script * Change escaping method with zero-width space Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
What kind of changes does this PR include?
--with––instead, as to not break discord markdown.Description
--flagsin Discord CongratsBot #1615