Skip to content

Comments

i18n(ja): add sessions.mdx#13198

Merged
yanthomasdev merged 3 commits intowithastro:mainfrom
morinokami:i18n-ja-sessions-0
Feb 5, 2026
Merged

i18n(ja): add sessions.mdx#13198
yanthomasdev merged 3 commits intowithastro:mainfrom
morinokami:i18n-ja-sessions-0

Conversation

@morinokami
Copy link
Member

@morinokami morinokami commented Feb 1, 2026

Description (required)

Translate sessions.mdx into Japanese.

Related issues & labels (optional)

  • Suggested label: i18n

@netlify
Copy link

netlify bot commented Feb 1, 2026 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e4f74ad
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/69850caf53c7860008f0db39
😎 Deploy Preview https://deploy-preview-13198--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Feb 1, 2026
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Feb 1, 2026 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
ja/guides/sessions.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918
Copy link
Member

sarah11918 commented Feb 2, 2026

@morinokami , we are not accepting newly translated pages to v5 docs right now since in most cases they will immediately be out of date. But it looks like the only updating going from v5 docs to v6 is:

image

If you could PR this translation instead to v6, with the indicated change, then I think it makes more sense to just have this page fresh for v6 docs! (Note: the two branches are VERY different, so you might want to just start over and add this page fresh to the v6 branch in a new PR.)

@morinokami
Copy link
Member Author

morinokami commented Feb 2, 2026

@sarah11918 Thank you for letting me know! I’ve recreated the PR for v6: #13211. I didn’t realize there would be such a large difference in v6, so sorry for the extra work of having to check whether my PRs could be merged 😅

@sarah11918
Copy link
Member

sarah11918 commented Feb 2, 2026

No worries @morinokami ! It's a chaotic time for us all! 😅

Thanks for #13211 so that we will have updated docs when we release v6 docs! That makes it easier to accept this for v5! 👍

@sarah11918
Copy link
Member

sarah11918 commented Feb 2, 2026

(I have not done any kind of review of the content, just confirming that it's OK to accept this translation even though we're not currently accepting new, untranslated pages because the accompanying PR to v6 will mean we are not launching with outdated content immediately on v6 release!)

Yusaku01
Yusaku01 reviewed Feb 4, 2026
View reviewed changes
Copy link
Contributor

@Yusaku01 Yusaku01 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1つコメントを入れさせて頂きました🙏
(こちら、新しい方のPRに付けた方がいいですかね😓)

src/content/docs/ja/guides/sessions.mdx Outdated

## セッションデータの型

デフォルトではセッションデータは型がなく、任意のキーに任意のデータを保存できます。値は[devalue](https://github.com/Rich-Harris/devalue)を使用してシリアライズ・デシリアライズされます。これはコンテンツコレクションやアクションで使用されているのと同じライブラリです。そのため、サポートされる型も同じで、文字列、数値、`Date`、`Map`、`Set`、`URL`、配列、プレーンなオブジェクトが含まれます。
Copy link
Contributor

@Yusaku01 Yusaku01 Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morinokami

デフォルトではセッションデータは型がなく、

セッションデータには

のように、個人的には『に』を入れた方がより自然な気がしました🤔

Copy link
Member Author

@morinokami morinokami Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます、そのまま採用させてもらいました 🙏 （#13211 の方も同じ修正を入れました）

Copy link
Contributor

@Yusaku01 Yusaku01 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございます！確認しました！！

@morinokami morinokami requested a review from Yusaku01 February 5, 2026 15:00
@Yusaku01
Copy link
Contributor

Yusaku01 commented Feb 5, 2026 •
edited
Loading

Content is LGTM itself.

yanthomasdev
yanthomasdev approved these changes Feb 5, 2026
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yanthomasdev yanthomasdev merged commit f26a587 into withastro:main Feb 5, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanthomasdev yanthomasdev yanthomasdev approved these changes

+1 more reviewer

@Yusaku01 Yusaku01 Yusaku01 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morinokami @astrobot-houston @sarah11918 @Yusaku01 @yanthomasdev