Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
@ematipico - If you look at the bottom of the "Files changed" view, you can see that there are two pages with an anchor link to a section heading you've changed. This is why the link check has failed. (If you look at the results of the link check, it will tell you there are 11 problems, but 10 of them are caused because they are creating pages using the content of the English page with the broken link; the Korean page is the only one that separately needs manually updating) Can you please update those anchor links to match the new heading, and then I think all the tests should pass! |
👀 The failing links come from |
|
@sarah11918 @ArmandPhilippot Should I just revert the changes and limit myself to the english version? |
|
If you don't want to waste time struggling with links, this is probably easier, yes. 😄 In any case, the Adapter and Integrations references will require an update to the translations. So, I don't think it's an issue to keep |
|
@sarah11918 @ArmandPhilippot Discovered more changes, and addressed the link failures |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thanks, Ema! Unfortunately with the new changes you discovered, we'll need more changes. 😅 I think it's fine if you only apply that to the English version:
- on
@astrojs/netlify, becausestaticHeadersis no longer experimental, I think we can remove the "Experimental features" section and movestaticHeadersin "Usage". - same for
@astrojs/vercel - on
@astrojs/node, this is rather a nit, I guess we should keep the experimental flags grouped, so we might want to movestaticHeadersaboveexperimentalDisableStreaming.
I also suggested to bump the version in each <Since /> component. I'm not sure we have something about that in AD², but we usually use the stable version rather than the experimental one.
|
Ok, let me revert the changes to only target english. Then I will apply your suggestions |
408c124 to
148166b
Compare
|
@ArmandPhilippot I force pushed, now the changes only affect the english version. So, here's the thing though: for vercel and netlify, there aren't experimental features anymore. Should I remove the paragraph? |
|
@ematipico Yes, I think it would make sense because these sections are now empty! |
sarah11918
left a comment
There was a problem hiding this comment.
Just comments re: whether we still need the experimental section and to check carefully version numbers!
|
@ArmandPhilippot and @sarah11918 please review again |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thanks for the update Ema!
I think we're almost there! There is an issue with a code snippet in @astrojs/node and, in @astrojs/vercel, the section should be moved under "Configuration". After that, this looks pretty good to me!
sarah11918
left a comment
There was a problem hiding this comment.
As far as I can tell, Armand caught everything! Should be the only changes still needed!
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
|
Let me know when this PR is ready for merging, so I can merge the code feature |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
LGTM, thanks Ema! And sorry my suggestion wasted time...
|
Thank you. I just merged the code pr |
sarah11918
left a comment
There was a problem hiding this comment.
Great! This PR is ready to merge when the feature is released! 🎉
Description (required)
This PR updates
experimentalStaticHeaderstostaticHeaders.The docs already use a very broad explanation, so it's there's no need to update their explanation.
For Astro version:
6.0. See astro PR #15258.