Skip to content

Comments

feat: update flag naming#13159

Merged
ematipico merged 8 commits intov6from
feat/stabilize-flag
Feb 5, 2026
Merged

feat: update flag naming#13159
ematipico merged 8 commits intov6from
feat/stabilize-flag

Conversation

@ematipico
Copy link
Member

Description (required)

This PR updates experimentalStaticHeaders to staticHeaders.

The docs already use a very broad explanation, so it's there's no need to update their explanation.

For Astro version: 6.0. See astro PR #15258.

@netlify
Copy link

netlify bot commented Jan 28, 2026

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit bcb0296
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6983688b4e0b370008e23a6b
😎 Deploy Preview https://deploy-preview-13159--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 28, 2026
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jan 28, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/integrations-guide/netlify.mdx Source changed, localizations will be marked as outdated.
en/guides/integrations-guide/node.mdx Source changed, localizations will be marked as outdated.
en/guides/integrations-guide/vercel.mdx Source changed, localizations will be marked as outdated.
en/reference/adapter-reference.mdx Source changed, localizations will be marked as outdated.
en/reference/integrations-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) 6.0 labels Jan 28, 2026
@sarah11918
Copy link
Member

@ematipico - If you look at the bottom of the "Files changed" view, you can see that there are two pages with an anchor link to a section heading you've changed. This is why the link check has failed.

(If you look at the results of the link check, it will tell you there are 11 problems, but 10 of them are caused because they are creating pages using the content of the English page with the broken link; the Korean page is the only one that separately needs manually updating)

Can you please update those anchor links to match the new heading, and then I think all the tests should pass!

@ArmandPhilippot
Copy link
Member

the Korean page is the only one that separately needs manually updating

👀
This means that some replacements are missing for adapter-reference. The Korean version isn't the only one to include experimentalStaticHeaders. There's also at least the French version 😄 and the Chinese version.

The failing links come from SSRManifest.csp.cspDestination (and the translations)

@ematipico
Copy link
Member Author

@sarah11918 @ArmandPhilippot Should I just revert the changes and limit myself to the english version?

@ArmandPhilippot
Copy link
Member

If you don't want to waste time struggling with links, this is probably easier, yes. 😄

In any case, the Adapter and Integrations references will require an update to the translations. So, I don't think it's an issue to keep experimentalStaticHeaders in the meantime!

@ematipico
Copy link
Member Author

@sarah11918 @ArmandPhilippot Discovered more changes, and addressed the link failures

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ema! Unfortunately with the new changes you discovered, we'll need more changes. 😅 I think it's fine if you only apply that to the English version:

  • on @astrojs/netlify, because staticHeaders is no longer experimental, I think we can remove the "Experimental features" section and move staticHeaders in "Usage".
  • same for @astrojs/vercel
  • on @astrojs/node, this is rather a nit, I guess we should keep the experimental flags grouped, so we might want to move staticHeaders above experimentalDisableStreaming.

I also suggested to bump the version in each <Since /> component. I'm not sure we have something about that in AD², but we usually use the stable version rather than the experimental one.

@ematipico
Copy link
Member Author

Ok, let me revert the changes to only target english. Then I will apply your suggestions

@ematipico ematipico force-pushed the feat/stabilize-flag branch from 408c124 to 148166b Compare January 30, 2026 13:22
@ematipico
Copy link
Member Author

@ArmandPhilippot I force pushed, now the changes only affect the english version. So, here's the thing though: for vercel and netlify, there aren't experimental features anymore. Should I remove the paragraph?

@ArmandPhilippot
Copy link
Member

@ematipico Yes, I think it would make sense because these sections are now empty!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just comments re: whether we still need the experimental section and to check carefully version numbers!

@ematipico
Copy link
Member Author

@ArmandPhilippot and @sarah11918 please review again

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update Ema!
I think we're almost there! There is an issue with a code snippet in @astrojs/node and, in @astrojs/vercel, the section should be moved under "Configuration". After that, this looks pretty good to me!

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, Armand caught everything! Should be the only changes still needed!

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@ematipico
Copy link
Member Author

ematipico commented Feb 4, 2026

Let me know when this PR is ready for merging, so I can merge the code feature

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Ema! And sorry my suggestion wasted time...

@ematipico
Copy link
Member Author

Thank you. I just merged the code pr

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This PR is ready to merge when the feature is released! 🎉

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Feb 4, 2026
@ematipico ematipico merged commit 9b9eb0e into v6 Feb 5, 2026
10 checks passed
@ematipico ematipico deleted the feat/stabilize-flag branch February 5, 2026 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.0 i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants