-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Remove unnecessary double dashes in npm commands #12781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
|
Hi Marcus, I checked using the minimal template on Linux and this seems to work for me: The escape characters before the options (e.g. Since I don't have PowerShell, can you confirm the environment used for your test? I think on Linux/Mac the escapement was never a requirement (but it was working). So, now, if it fails with PowerShell, maybe we should apply your changes here (and probably on other pages?). Otherwise, I wonder why it's not working for you... |
|
IIRC it’s not only PowerShell in this case. PowerShell needed double double dashes (i.e. |
|
Oh you're right, I mixed up things! I read that as if it were a double So, |
|
Ahh, right, this is my bad, I forgot this documentation is in the context of I was adding it in my package.json like this, providing the arguments directly to the Astro CLI: {
"scripts": {
"dev": "astro dev --mode dev"
}
}(and then just In which case I know you usually have to Sorry! I'll blame monday morning brain |
Description (required)
astro dev -- --mode devdoes not work,astro dev --mode devdoes work. Not sure if this was changed recently and docs weren't updated, but this had me stuck for a while.Not sure about --devOutput but since it's documented as a CLI command to astro I assume that the double dashes should be removed for that as well.
Related issues & labels (optional)
No need for first time contributor, I am @MarcusOtter on work account 🕵️