Skip to content

Conversation

@florian-lefebvre
Copy link
Member

Co-authored-by: Sarah Rainsberger 5098874+sarah11918@users.noreply.github.com

Description (required)

I don't think docs need to be updated elsewhere because the things getting deprecated were already not documented anymore

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 6.0. See astro PR #14462.

@florian-lefebvre florian-lefebvre added this to the v6.0.0 docs milestone Sep 30, 2025
@netlify
Copy link

netlify bot commented Sep 30, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 0211a86
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68dd4b5ca9c17b0008c564f7
😎 Deploy Preview https://deploy-preview-12469--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Sep 30, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/upgrade-to/v6.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small nit, otherwise this looks good. And I couldn't find any occurrences elsewhere in the docs. So yes, I think there is nothing else to update!

Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look great! As you'll notice, because these are potentially "silent killers" hiding in waiting, deprecated a long time ago but then just been hanging around... I was a little more forceful in describing that they need to be removed for the specific reason that they'll now cause errors vs just saying they're not necessary anymore. These feel like things that could secretly have been hiding in people's projects for a long time if they exist, so maybe worth being a bit extra here.


<SourcePR number="14462" title="feat: clean deprecated APIs"/>

In Astro 4.0, the `handleForms` prop of the `<ClientRouter />` component was deprecated.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to correct this, thinking you surely meant it was deprecated in 5.0, but nope! It has stuck around! 😂

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny more suggestion in keeping with the others, but LGTM!

Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
@florian-lefebvre florian-lefebvre merged commit e840333 into v6 Oct 1, 2025
6 of 11 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/clean-deprecated-apis branch October 1, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants