Skip to content

Comments

Add prerendered error page setting for node#12131

Merged
sarah11918 merged 4 commits intomainfrom
node-prerender-error-host
Aug 12, 2025
Merged

Add prerendered error page setting for node#12131
sarah11918 merged 4 commits intomainfrom
node-prerender-error-host

Conversation

@ascorbic
Copy link
Contributor

@ascorbic ascorbic commented Aug 8, 2025

Description (required)

Adds docs for the experimentalErrorPageHost setting in @astrojs/node@9.4.0. Also corrects an related error in the docs for error pages that I spotted

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@ascorbic ascorbic added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. labels Aug 8, 2025
@netlify
Copy link

netlify bot commented Aug 8, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit f43b47c
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/689b640387e26b000820314d
😎 Deploy Preview https://deploy-preview-12131--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@ascorbic ascorbic added this to the 5.13.0 milestone Aug 8, 2025
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Aug 8, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/basics/astro-pages.mdx Source changed, localizations will be marked as outdated.
en/guides/integrations-guide/node.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ascorbic
Copy link
Contributor Author

ascorbic commented Aug 8, 2025

Adding to milestone, but this can be released before as it's in an adapter that's already released

bjohansebas
bjohansebas approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

yanthomasdev
yanthomasdev reviewed Aug 8, 2025
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, two small nits from me.

@sarah11918 sarah11918 added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels Aug 8, 2025
@sarah11918 @yanthomasdev
Apply suggestions from Yan code review
590d0bc 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
sarah11918
sarah11918 reviewed Aug 12, 2025
View reviewed changes
yanthomasdev
yanthomasdev approved these changes Aug 12, 2025
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Aug 12, 2025
@sarah11918
Copy link
Member

sarah11918 commented Aug 12, 2025

Merging now, since the feature is already released!

@sarah11918 sarah11918 merged commit 32c4407 into main Aug 12, 2025
10 checks passed
@sarah11918 sarah11918 deleted the node-prerender-error-host branch August 12, 2025 16:53
angelmarfil pushed a commit to angelmarfil/docs that referenced this pull request Aug 13, 2025
@ascorbic @sarah11918
@yanthomasdev @bjohansebas @angelmarfil
Add prerendered error page setting for node (withastro#12131)
587f52b 
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Co-authored-by: bjohansebas <103585995+bjohansebas@users.noreply.github.com>
@jsparkdev jsparkdev mentioned this pull request Aug 13, 2025
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Aug 13, 2025
@ArmandPhilippot
i18n(fr): update integrations-guide/node & basics/astro-pages
bab2903 
See withastro#12131
@ArmandPhilippot ArmandPhilippot mentioned this pull request Aug 13, 2025
Merged
@vrabe vrabe mentioned this pull request Aug 24, 2025
Merged
@liruifengv liruifengv mentioned this pull request Aug 26, 2025
Merged
@liruifengv liruifengv mentioned this pull request Sep 22, 2025
Merged
@morinokami morinokami mentioned this pull request Jan 31, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@yanthomasdev yanthomasdev yanthomasdev approved these changes

+1 more reviewer

@bjohansebas bjohansebas bjohansebas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!

Projects

None yet

Milestone

5.13.0

Development

Successfully merging this pull request may close these issues.

5 participants

@ascorbic @astrobot-houston @sarah11918 @yanthomasdev @bjohansebas