Skip to content

Conversation

HALQME
Copy link
Contributor

@HALQME HALQME commented Apr 16, 2025

Description (required)

Update guides/view-transitions.mdx in Japanese.

Related issues & labels (optional)

  • Suggested label: i18n
  • My Astro Discord username: halqm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Apr 16, 2025
Copy link

netlify bot commented Apr 16, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit c78e8b4
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6814be4bf933160008899d6b
😎 Deploy Preview https://deploy-preview-11476--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 16, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
ja/guides/upgrade-to/v3.mdx Localization changed, will be marked as complete.
ja/guides/view-transitions.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

Copy link
Contributor

@jp-knj jp-knj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thanks for this excellent PR! 🎉

Your translation is fluent and strictly conforms to our Japanese style guide.
I’d appreciate it if you could apply the code I proposed in the comment.

PR👍 ありがとうございます!
確認できましたら、コメントでご提案したコードを取り込んでいただけますと幸いです。

@jp-knj
Copy link
Contributor

jp-knj commented Apr 28, 2025

@HALQME 確認お願いします!

@HALQME
Copy link
Contributor Author

HALQME commented Apr 28, 2025

@HALQME 確認お願いします!

夕方くらいに見ます〜!ありがとうございます!!!

@jp-knj
Copy link
Contributor

jp-knj commented Apr 30, 2025

@HALQME
ありがとうございます。

"Files Changed" タブで "Add suggestion to batch" 機能を使うようお願いします。
「コメントを受けたところは commit すればよい」と思われるかもしれませんが、サジェスチョンごとにコミットとの確認をしなければならず、レビューの負担がそこそこありますので、対応ほどお願いします。

ご参考に
https://github.com/withastro/docs/pull/7564/commits

Copy link
Contributor Author

@HALQME HALQME left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HALQME
ありがとうございます。

"Files Changed" タブで "Add suggestion to batch" 機能を使うようお願いします。
「コメントを受けたところは commit すればよい」と思われるかもしれませんが、サジェスチョンごとにコミットとの確認をしなければならず、レビューの負担がそこそこありますので、対応ほどお願いします。

ご参考に
https://github.com/withastro/docs/pull/7564/commits

すみません全部VSCodeで済ませてるんで全然知りませんでした💦
github.comだったらあるんですね

HALQME and others added 2 commits April 30, 2025 10:10
Co-authored-by: knj <70939128+jp-knj@users.noreply.github.com>
@jp-knj
Copy link
Contributor

jp-knj commented Apr 30, 2025

LGTM!
対応してくださり、ありがとうございました 👍

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job!

@yanthomasdev yanthomasdev merged commit c5dac0b into withastro:main May 2, 2025
10 checks passed
@HALQME HALQME deleted the i18n-ja-guides-view-transitions branch May 2, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants