Skip to content

Conversation

ghost
Copy link

@ghost ghost commented Apr 10, 2025

Description (required)

Update concepts/islands.mdx

Reference

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Apr 10, 2025
Copy link

netlify bot commented Apr 10, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7cbdcae
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/680412997f281e000818c0a9
😎 Deploy Preview https://deploy-preview-11409--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Apr 10, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
es/concepts/islands.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gracias Marcos! 😁

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

el titulo de #creando-una-isla tiene que ser cambiado a Islas del cliente y revisar los docs en inglés para ver si el contenido hace match https://docs.astro.build/en/concepts/islands/#client-islands

Marcos Corrochano Arroyo and others added 3 commits April 14, 2025 23:23
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@ghost
Copy link
Author

ghost commented Apr 15, 2025

@dreyfus92 ya he aplicado los cambios que has sugerido! Gracias por la revisión! 🙌

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muchas gracias @drixswe, LGTM ✅

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

falta cambiar el titulo Creando una isla a Islas de cliente y checar que esa sección coincida con la versión que esta en prod

@dreyfus92 dreyfus92 merged commit 82ac2c3 into withastro:main Apr 19, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants