Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update error reference docs #10196

Closed
wants to merge 0 commits into from
Closed

ci: update error reference docs #10196

wants to merge 0 commits into from

Conversation

astrobot-houston
Copy link
Contributor

This PR is auto-generated by a nightly GitHub action to update the error reference docs from source code in withastro/astro.

@astrobot-houston astrobot-houston added the ci Automated PRs created by CI, or PRs about automation - ask @delucis for help! label Dec 5, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 5, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 0e3877b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6752f8d442d69900084737ea
😎 Deploy Preview https://deploy-preview-10196--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Contributor Author

astrobot-houston commented Dec 5, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/errors/redirect-with-no-location.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Live docs are correct. This is now my reference for errors to change at the source!

Created withastro/astro#12645

@astrobot-houston astrobot-houston force-pushed the ci/docgen-errors branch 2 times, most recently from 0b9df04 to bd20fec Compare December 5, 2024 13:36
delucis
delucis reviewed Dec 5, 2024
View reviewed changes
src/content/docs/en/reference/errors/redirect-with-no-location.mdx Outdated
@@ -17,6 +17,6 @@ import DontEditWarning from '~/components/DontEditWarning.astro'
A redirect must be given a location with the `Location` header.

**See Also:**
- [Astro.redirect](/en/reference/api-reference/#redirect)
- [Astro.redirect](/en/reference/api-reference/#astroredirect)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So close!

Copy link
Member

@sarah11918 sarah11918 Dec 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack! lol I did a search for #astro and this one never came up! 😅

sarah11918
sarah11918 requested changes Dec 5, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, blocking because live docs is correct, and the source is wrong and needs updating!

Waiting for 12653 to close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis left review comments

@sarah11918 sarah11918 sarah11918 requested changes

Assignees
No one assigned
Labels
ci Automated PRs created by CI, or PRs about automation - ask @delucis for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@astrobot-houston @delucis @sarah11918