Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch set-output deprecation in workflows #9543

Merged
merged 2 commits into from
Jan 3, 2024

Conversation

matiboux
Copy link
Contributor

Changes

I've noticed some workflows are showing warning about set-output deprecation.

This PR updates all workflows that are using set-output to use the new environment files instead.

This has been done following GitHub's "GitHub Actions: Deprecating save-state and set-output commands" blog post and instructions on updating.

Testing

I've run syntax checks on the updated workflow files.
Their behavior should not change.

The check-merge.yml workflow should run on this PR, succeed, and the step "Check if any changesets contain minor changes" should not show any warning anymore.

The main.yml and release.yml workflows won't run on this PR. I don't know how to rigorously test them further after syntax checks.

Docs

This only fixes a deprecation warning.

See GitHub's blog post:
"GitHub Actions: Deprecating save-state and set-output commands"
Copy link

changeset-bot bot commented Dec 29, 2023

⚠️ No Changeset found

Latest commit: 05eee1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Dec 29, 2023
Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
@matiboux matiboux changed the title Patches workflows after set-output deprecation Patch set-output deprecation in workflows Dec 29, 2023
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm not a bash expert, so hoping to get another eye on this before merging.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, I had been meaning to clean this up for a while. Thanks so much for contributing!

@bluwy bluwy merged commit 1099c64 into withastro:main Jan 3, 2024
13 checks passed
@matiboux matiboux deleted the patch-set-output-deprecated branch January 3, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 action Modifies GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants