-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support setting rootMargin for client:visible
#9363
Merged
Merged
Commits on Dec 7, 2023
-
feat: support setting rootMargin for
client:visible
This support adding optional `rootMargin` to the `IntersectionObserver` options. This gives the developer the optional choice to hydrate a bit before the astro-island enters the viewport.
Configuration menu - View commit details
-
Copy full SHA for 693e75f - Browse repository at this point
Copy the full SHA 693e75fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54883c4 - Browse repository at this point
Copy the full SHA 54883c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for fd8380d - Browse repository at this point
Copy the full SHA fd8380dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5552050 - Browse repository at this point
Copy the full SHA 5552050View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a8b4cd - Browse repository at this point
Copy the full SHA 4a8b4cdView commit details
Commits on Dec 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for bf11b64 - Browse repository at this point
Copy the full SHA bf11b64View commit details
Commits on Dec 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 893c7a2 - Browse repository at this point
Copy the full SHA 893c7a2View commit details
Commits on Jan 2, 2024
-
fix: update .changeset/stupid-peas-juggle.md
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Configuration menu - View commit details
-
Copy full SHA for afd5eb3 - Browse repository at this point
Copy the full SHA afd5eb3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.