-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure dev overlay x-ray highlight goes over the island #9227
Conversation
🦋 Changeset detectedLatest commit: 7d5785a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
!preview xray |
⚖️ Bundle Size CheckLatest commit: f6eebaf
|
Snapshots have been released for the following packages:
Publish Log
Build Log
|
!preview xray |
Snapshots have been released for the following packages:
Publish Log
Build Log
|
f6eebaf
to
7d5785a
Compare
@@ -41,6 +41,10 @@ export default { | |||
const tooltip = buildIslandTooltip(island); | |||
attachTooltipToHighlight(highlight, tooltip, islandElement); | |||
|
|||
// Set the z-index to be 1 higher than the greatest z-index in the stack. | |||
const zIndex = getHighlightZIndex(islandElement); | |||
tooltip.style.zIndex = highlight.style.zIndex = zIndex+''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting that setting this to some high number like 9999
would work as well. I thought it would be better to allow other things to possibly go on top, like other plugins. So instead this calculates the next z-index
for an element.
@@ -41,6 +41,10 @@ export default { | |||
const tooltip = buildIslandTooltip(island); | |||
attachTooltipToHighlight(highlight, tooltip, islandElement); | |||
|
|||
// Set the z-index to be 1 higher than the greatest z-index in the stack. | |||
const zIndex = getHighlightZIndex(islandElement); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably also be done for audits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I do that in a follow up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure!
Changes
Fixes docs usage
Testing
Docs
N/A