Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve high contrast mode with the dev overlay #9218

Merged
merged 2 commits into from
Nov 29, 2023
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • Improves high contrast
  • Mostly this is just making backgrounds white and text / fill black.
high-contrast.mp4

Testing

N/A

Docs

N/A

Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: 9b3d279

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Nov 28, 2023
Copy link
Member

@martrapp martrapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM!

packages/astro/src/runtime/client/dev-overlay/overlay.ts Outdated Show resolved Hide resolved
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matthewp matthewp merged commit f4401c8 into next Nov 29, 2023
13 checks passed
@matthewp matthewp deleted the overlay-high-contrast branch November 29, 2023 16:08
This was referenced Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants