Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue): vue regular script block exports not being recognized inside editor #8998
fix(vue): vue regular script block exports not being recognized inside editor #8998
Changes from 4 commits
d16a16d
a0d1d9b
a491105
df12478
ab1b88a
b450334
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ultimately, this module shouldn't use a regex to get the types, it should use something like https://github.com/vuejs/language-tools/tree/master/packages/component-meta and https://github.com/vuejs/language-tools/tree/master/packages/component-type-helpers
which should support everything (or at least, if it doesn't, would be a bug upstream that's not in our hands)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I have looked briefly into these packages after I opened this PR and its not so far I haven't found an easy way.
component-meta gives narrows prop types and output loses generic information, so
T extends string
becomes just string.component-type-helpers needs a component instance types, to import which requires vue language server I think and still it loses all generic information and narrows types. I am not sure how would that work with virtual file.
Current approach is not sustainable and prone to fail, right now astro doesn't account for
https://vuejs.org/guide/typescript/composition-api.html#props-default-values
or experimental defineModel and so on and yet I am not sure how to get something better in a short term.Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.