Prevent the route announcer from being visible #8977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c642708 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
Princesseuh
reviewed
Nov 1, 2023
| @@ -7,7 +7,20 @@ export interface Props { | |||
|
|
|||
| const { fallback = 'animate' } = Astro.props as Props; | |||
There was a problem hiding this comment.
Unrelated to this PR, but is the as Props needed? Our tooling should take care of it.
There was a problem hiding this comment.
It was when I worked on vscode 😡
Princesseuh
approved these changes
Nov 1, 2023
natemoo-re
approved these changes
Nov 1, 2023
Merged
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
* Prevent the route announcer from being visible * Update the number of expected styles in the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
viewtransition.cssis only added if there are uses of thetransition:directives. In apps that do not use those, the styles are never added.Testing
Docs
N/A, bug fix