Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(middleware): undo config's path to URL encoding #8614

Merged
merged 3 commits into from
Sep 21, 2023
Merged

fix(middleware): undo config's path to URL encoding #8614

merged 3 commits into from
Sep 21, 2023

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Sep 21, 2023 •
edited
Loading

Changes

Testing

  • Co-opted fixtures/middleware-dev by renaming it. It was testing more than just the dev mode already.

Docs

Does not affect usage.

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 97289ae

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 21, 2023
@lilnasy lilnasy mentioned this pull request Sep 21, 2023
Closed
1 task
@lilnasy lilnasy marked this pull request as draft September 21, 2023 03:32
@lilnasy
Copy link
Contributor Author

lilnasy commented Sep 21, 2023 •
edited
Loading

Converting to draft as there seem to be issues with spaces unrelated to middleware as well. Had to reinstall node_modules in the repro project.

@lilnasy lilnasy marked this pull request as ready for review September 21, 2023 04:53
ematipico
ematipico approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see this coming! Thank you for fixing this!

@ematipico ematipico merged commit 4398e92 into withastro:main Sep 21, 2023
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Sep 21, 2023
Merged
@lilnasy lilnasy mentioned this pull request Sep 21, 2023
Closed
1 task
@lilnasy lilnasy deleted the fix-8191 branch September 23, 2023 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Middleware intermittently not working on iOS/ARM
2 participants
@lilnasy @ematipico