Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect page type icon not properly displayed #8579

Merged
merged 3 commits into from
Sep 18, 2023
Merged

fix: redirect page type icon not properly displayed #8579

merged 3 commits into from
Sep 18, 2023

Conversation

rishi-raj-jain
Copy link
Contributor

fix #8498

@changeset-bot
Copy link

changeset-bot bot commented Sep 16, 2023

🦋 Changeset detected

Latest commit: 3e238ce

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 16, 2023
@florian-lefebvre
Copy link
Member

Shouldn't it show a different symbol for redirects?

@rishi-raj-jain
Copy link
Contributor Author

rishi-raj-jain commented Sep 17, 2023

I tried finding one but couldn't think of then read the expectation in the issue that was created for this "it should be shown as a static built page"

but anyways, what would you suggest?

Copy link
Member

@florian-lefebvre florian-lefebvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt?

packages/astro/src/core/build/generate.ts Show resolved Hide resolved
.changeset/two-jeans-serve.md Outdated Show resolved Hide resolved
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bluwy bluwy merged commit 0586e20 into withastro:main Sep 18, 2023
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

redirect page type icon not properly displayed
5 participants