-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine CLI flag descriptions for clarity #8545
Refine CLI flag descriptions for clarity #8545
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for these improvements! I know people will be thrilled with them.
Waiting for a review from @withastro/maintainers-docs which I've been told is coming tomorrow! |
Hi @jacobthesheep ! Can you please revise this PR to only include the new options you're adding, and no changes to existing flags? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting that only new flags be added; removing changes to existing content.
I'm not adding new flags. I just updated the wording for existing flags. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching these typos and adding some missing flags, @jacobthesheep !
I'm not sure about the formatting changes though, that doesn't seem right to me, so let me know if I'm missing something.
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sorry about that. Thanks for catching those. |
still for Nate to do one final check!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the missing info and the typo fixes! Appreciate it.
Changes
create-astro
CLI flagsTesting
N/A
Docs
@withastro/maintainers-docs should probably add docs for this