Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for checking media type in CSR #8537

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Fix for checking media type in CSR #8537

merged 5 commits into from
Sep 13, 2023

Conversation

martrapp
Copy link
Member

Changes

Fix for https://discord.com/channels/830184174198718474/1151397066212388924/1151397066212388924
When checking the content type of the fetched document I confused media type with content type.
Fixed that

Testing

Still passes all e2e tests :)

Docs

n/a bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2023

🦋 Changeset detected

Latest commit: 3738a0c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 13, 2023
@martrapp martrapp changed the title Media type Fix for checking media type in CSR Sep 13, 2023
@martrapp martrapp mentioned this pull request Sep 13, 2023
.* is longest possible run, but a dollar won't harm us :)

Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
@martrapp martrapp marked this pull request as draft September 13, 2023 14:13
@martrapp martrapp marked this pull request as ready for review September 13, 2023 14:23
@martrapp martrapp marked this pull request as draft September 13, 2023 18:35
@martrapp martrapp marked this pull request as ready for review September 13, 2023 18:37
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the fix!

@natemoo-re natemoo-re merged commit f95febf into withastro:main Sep 13, 2023
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Sep 13, 2023
@martrapp martrapp deleted the media-type branch September 13, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants