Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: correct description of attribute option in scopedStyleStrategy #8506

Conversation

mascii
Copy link
Contributor

@mascii mascii commented Sep 11, 2023

Changes

fix: #8474

It was commented that setting scopedStyleStrategy to attribute causes specificity increase is intentional, so the JSDoc regarding this has been updated to reflect it.

Testing

N/A (JSDoc fixes only)

Docs

N/A

@mascii mascii requested a review from a team as a code owner September 11, 2023 14:19
@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2023

🦋 Changeset detected

Latest commit: a48e682

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Sep 11, 2023
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Allowing myself to merge this in without a docs approval since this is only a technical fix.

@Princesseuh Princesseuh merged commit 23f9536 into withastro:main Sep 11, 2023
14 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting scopedStyleStrategy to attribute causes specificity increase
2 participants