Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed <style> with type="text/css" from inline output at build time #8480

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Removed <style> with type="text/css" from inline output at build time #8480

merged 4 commits into from
Sep 12, 2023

Conversation

yamanoku
Copy link
Contributor

@yamanoku yamanoku commented Sep 10, 2023 •
edited
Loading

Changes

  • It is deprecated to add type="text/css" to style elements.

Authors should not specify a type attribute on a style element.
https://html.spec.whatwg.org/multipage/obsolete.html#obsolete-but-conforming-features

Deprecated attributes

type
This attribute should not be provided
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/style#deprecated_attributes

Warning: The type attribute for the style element is not needed and should be omitted.

Testing

  • Remove the part that detects type="text/css".
    • packages/integrations/deno/test/basics.test.ts
    • packages/integrations/node/test/prerender-404-500.test.js

@changeset-bot
Copy link

changeset-bot bot commented Sep 10, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 9c8b79a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Sep 10, 2023
@yamanoku yamanoku marked this pull request as ready for review September 10, 2023 05:31
@bluwy bluwy merged commit 6448258 into withastro:main Sep 12, 2023
12 of 14 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Sep 12, 2023
Merged
@yamanoku yamanoku deleted the del-style-props-text-css branch September 12, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yamanoku @bluwy