Support AVIF input assets #8380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1f402a2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
This reverts commit c0be387.
Merged
Princesseuh
added a commit
that referenced
this pull request
Sep 11, 2023
This reverts commit 345cb4a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
.aviffiles in the assets vite plugin and constantsResolves #8056, #8376
Note: the "image-size" package was previoulsy vendored due to some issues with the CJS format. The "probe-image-size" package also appears to use CJS format, but I haven't personally experienced issues with it. Perhaps someone who knows more about the issues that were faced with "image-size" could verify that this dependency doesn't cause the same problem (cc @Princesseuh)
Testing
Added a test case to the "astro-assets" test. The AVIF image was created from this CC0 image and converted to AVIF using Squoosh.
I also manually tested importing an AVIF image in the minimal example.
Docs
No docs added because the existing docs don't specify supported image input formats.