Move hoisted script analysis optimization as experimental #8011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9c775a5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
commented
Aug 9, 2023
Comment on lines
-39
to
+46
| walk(parentInfo.ast, { | ||
| enter(node) { | ||
| if (node.type === 'ImportDeclaration') { | ||
| imports.push(node as ImportDeclaration); | ||
| } else if ( | ||
| node.type === 'ExportDefaultDeclaration' || | ||
| node.type === 'ExportNamedDeclaration' | ||
| ) { | ||
| exports.push(node as ExportNamedDeclaration | ExportDefaultDeclaration); | ||
| } | ||
| }, | ||
| }); | ||
| // All of the aliases the current component is imported as | ||
| for (const node of (parentInfo.ast as any).body) { | ||
| if (node.type === 'ImportDeclaration') { | ||
| imports.push(node); | ||
| } else if (node.type === 'ExportDefaultDeclaration' || node.type === 'ExportNamedDeclaration') { | ||
| exports.push(node); | ||
| } | ||
| } |
There was a problem hiding this comment.
Import and exports declarations are top level only, so use this optimization.
ematipico
approved these changes
Aug 9, 2023
matthewp
approved these changes
Aug 9, 2023
natemoo-re
approved these changes
Aug 9, 2023
sarah11918
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
One small suggestion to make this A++, @bluwy! (OK, to make my life easier in the future... but that still counts as A++ in my books!!) 😉
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Merged
1 task
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #7744
Supersedes and closes #7997
Move the feature in #7707 behind an experimental flag. And added extra comments to make the analysis easier to follow.
Testing
Updated hoisted script test to enable the experimental flags.
Docs
Added the jsdocs. cc @withastro/maintainers-docs for feedback!