Fix examples check hang #7998
Merged
Fix examples check hang #7998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0e4d82c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Here's the manual run: https://github.com/withastro/astro/actions/runs/5799000951. It seems to work now, however they are actual fails because |
natemoo-re
approved these changes
Aug 8, 2023
github-actions
bot
added
the
pkg: astro
ematipico
approved these changes
Aug 9, 2023
|
Ran the examples check CI manually, it now works! https://github.com/withastro/astro/actions/runs/5807000509/job/15741026038 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The examples check workflow was hanging as
@astrojs/checkwasn't installed for the examples, and it was requesting user input the install it.This PR fixes it by installing
@astrojs/checkat the monorepo root.Testing
Examples check should pass now.
Docs
n/a