Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use workspace packages #7894

Merged
merged 1 commit into from
Aug 1, 2023
Merged

chore: use workspace packages #7894

merged 1 commit into from
Aug 1, 2023

Conversation

ematipico
Copy link
Member

Changes

Our release action is failing because it can't resolve the packages. Instead of using packages from npm, this PR attempts to fix it by using the workspace: protocol.

I don't have enough background to know why we don't use the workspace package, so please if you know, tell me. When I used pnpm workspaces in the past, I used to use the workspace: protocol for internal dependencies.

Testing

Merge it and see if it works. Unfortunately the release.yml doesn't can't be triggered.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Aug 1, 2023

⚠️ No Changeset found

Latest commit: f9f585d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Aug 1, 2023
@ematipico ematipico merged commit 62b92b8 into next Aug 1, 2023
13 checks passed
@ematipico ematipico deleted the feat/normalize-packages branch August 1, 2023 11:06
ematipico added a commit that referenced this pull request Aug 1, 2023
ematipico added a commit that referenced this pull request Aug 3, 2023
ematipico added a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants