Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scan getStaticPaths only in .astro files #7876

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

ematipico
Copy link
Member

Changes

Closes #7869

Testing

I checked manually

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2023

🦋 Changeset detected

Latest commit: 7ec274a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 31, 2023
@ematipico ematipico requested a review from bluwy July 31, 2023 14:41
@ematipico ematipico force-pushed the fix/function-check-scanner-plt-740 branch from 74cfb8d to db401d3 Compare July 31, 2023 14:56
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC if we really want to do this right, we can also borrow the exports values from es-module-lexer 🤔 But this also works for me for now.

@ematipico ematipico requested a review from a team as a code owner July 31, 2023 16:07
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jul 31, 2023
@ematipico ematipico force-pushed the fix/function-check-scanner-plt-740 branch from 3bc4567 to 7ec274a Compare July 31, 2023 16:08
@github-actions github-actions bot removed the pkg: integration Related to any renderer integration (scope) label Jul 31, 2023
@ematipico ematipico merged commit 89d015d into main Jul 31, 2023
13 checks passed
@ematipico ematipico deleted the fix/function-check-scanner-plt-740 branch July 31, 2023 16:24
This was referenced Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning: The getStaticPaths() statement has been ignored because output: "server" is set.
2 participants