Fix "res.writeHead is not a function" in Express/node middleware

[DixCouleur]

Changes

Fix #7590

add "error" argument to nodeMiddleware handler function

Testing

#7590 works correctly

Docs

bug fix

[changeset-bot]

🦋 Changeset detected

Latest commit: a8e1272

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[natemoo-re]

Thanks so much for the PR, we really appreciate it! This change looks good but there seems to be a type error. Once that's fixed, this should be good to go!

[DixCouleur]

Thanks so much for the PR, we really appreciate it! This change looks good but there seems to be a type error. Once that's fixed, this should be good to go!

i forgot to build before submit, i will fix it

[DixCouleur]

Thanks so much for the PR, we really appreciate it! This change looks good but there seems to be a type error. Once that's fixed, this should be good to go!

My idea is that I need to infer the type of parameters received by the handler in createExports in runtime🤔

[natemoo-re]

My idea is that I need to infer the type of parameters received by the handler in createExports in runtime 🤔

That seems to be overcomplicating things? Couldn't the handler accept any number of arguments (...args) and act differently depending on the shape of args?

[DixCouleur]

My idea is that I need to infer the type of parameters received by the handler in createExports in runtime 🤔

That seems to be overcomplicating things? Couldn't the handler accept any number of arguments (...args) and act differently depending on the shape of args?

Like args[0] instanceof IncomingMessage ?

[ematipico]

My idea is that I need to infer the type of parameters received by the handler in createExports in runtime 🤔

That seems to be overcomplicating things? Couldn't the handler accept any number of arguments (...args) and act differently depending on the shape of args?

Like args[0] instanceof IncomingMessage ?

Yeah that's the idea

[DixCouleur]

My idea is that I need to infer the type of parameters received by the handler in createExports in runtime 🤔

That seems to be overcomplicating things? Couldn't the handler accept any number of arguments (...args) and act differently depending on the shape of args?

Like args[0] instanceof IncomingMessage ?

Yeah that's the idea

I committed it with this idea

[natemoo-re]

Thanks for making that change, this looks great!