feat: restart server on markdoc config change #7467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ce2f157 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
bholmesdev
force-pushed
the
fix/restart-server-on-markdoc-config-change
branch
from
90867ab
to
d75d44d
Compare
bholmesdev
commented
Jun 23, 2023
Comment on lines
211
to
-208
| vite: { | ||
| vite: { | ||
| ssr: { |
There was a problem hiding this comment.
How long has that been there... :houston_panic:
bluwy
reviewed
Jun 26, 2023
bholmesdev
commented
Jun 26, 2023
| ); | ||
| for (const markdocConfigBase of SUPPORTED_MARKDOC_CONFIG_FILES) { | ||
| const absolutePath = new URL(markdocConfigBase, astroConfig.root); | ||
| if (entry === fileURLToPath(absolutePath)) { |
There was a problem hiding this comment.
I assume this will be the file path and not a Vite ID. Let me know if that's wrong!
bluwy
approved these changes
Jun 27, 2023
ematipico
approved these changes
Jun 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
server:setupto firerestart()whenever a support Markdoc config type has a change.Testing
Manually test that server restarts
Docs
N/A