Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove slash package #7440

Merged
merged 8 commits into from
Jun 23, 2023
Merged

Remove slash package #7440

merged 8 commits into from
Jun 23, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Jun 21, 2023

Changes

  • Remove slash package
  • Also remove unused supports-esm package (used to be used in the CLI)

The slash package doesn't do much unique except handling windows extended length path, which in a lot of case we don't need to. In some places, we're also doing slash('...').replace(/\\/g, '/') which nullifies slash altogether.

I've moved this utility to @astrojs/internal-helpers/path instead, and for tests, used a manual replace(/\\/g, '/') to reduce package dependencies.

Testing

Existing test should pass

Docs

n/a

@changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2023

🦋 Changeset detected

Latest commit: 310942c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Jun 21, 2023
@bluwy bluwy marked this pull request as draft June 22, 2023 06:48
@bluwy bluwy marked this pull request as ready for review June 22, 2023 07:20
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@bluwy bluwy merged commit 2b75399 into main Jun 23, 2023
@bluwy bluwy deleted the no-slash-package branch June 23, 2023 08:48
@astrobot-houston astrobot-houston mentioned this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants