Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
slash
packagesupports-esm
package (used to be used in the CLI)The
slash
package doesn't do much unique except handling windows extended length path, which in a lot of case we don't need to. In some places, we're also doingslash('...').replace(/\\/g, '/')
which nullifiesslash
altogether.I've moved this utility to
@astrojs/internal-helpers/path
instead, and for tests, used a manualreplace(/\\/g, '/')
to reduce package dependencies.Testing
Existing test should pass
Docs
n/a