Fix error stacktrace from Vite SSR runtime #7273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6dbf95f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
Looks like Vite's SSR stacktrace rewrite made the file path worse 👀 Gonna have to look into Vite |
1 task
matthewp
approved these changes
Jun 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Part of the fix for #5465
When we call
ssrLoadModuleto get a module processed by Vite, and call the module's runtime (e.g. it's exported function), we also need to fix the stacktrace there.Previously we're only fixing the stacktrace when we call
ssrLoadModule(module init).Also, when we call MagicString's
generateMap()API, we need to passhires: truetoo. Otherwise a low res map combined with another map (for multiple plugin transforms) will degrade the sourcemap accuracy/resolution. Causing offset issues.Testing
Manually tested with the issues repro
Docs
n/a. bug fix.