Add files field to packages #7104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 878a027 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: lit
|
Are the readme files still added ? |
|
Yeah, npm/pnpm etc will always pack |
ematipico
approved these changes
May 16, 2023
Princesseuh
approved these changes
May 17, 2023
Merged
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
ematipico
pushed a commit
that referenced
this pull request
Feb 5, 2025
ematipico
pushed a commit
that referenced
this pull request
Feb 6, 2025
ematipico
pushed a commit
that referenced
this pull request
Feb 6, 2025
ematipico
pushed a commit
that referenced
this pull request
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I found that many of out packages don't specify the
"files"field, resulting in src, tests, and turbo logs being published to npm. I've added the field for the packages missing it.Testing
Ran
npm packfor each packages to verify.Docs
n/a. refactor / bug fix.