-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent removal of nested slots within islands #7093
Conversation
🦋 Changeset detectedLatest commit: ef1d4da The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This PR is blocked because it contains a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking as this is a minor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes
astro-static-slot
instead ofastro-slot
when the slots are purely SSR. Doing this ensures that we only remove slots from SSR-only components and not from islands.supportsAstroStaticSlot
flag. Otherwise we preserve the old behavior.<slot />
in Vue component not rendering when hydrated #6669Testing
Docs
N/A, bug fix