Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(errors): Add simplified message for MarkdownImageNotFound #6718

Merged
merged 2 commits into from
Mar 31, 2023
Merged

fix(errors): Add simplified message for MarkdownImageNotFound #6718

merged 2 commits into from
Mar 31, 2023

Conversation

Princesseuh
Copy link
Member

Changes

Error references was broken because of the complex message, oops. I of all people should know this.

Testing

N/A

Docs

N/A

@Princesseuh Princesseuh requested a review from a team as a code owner March 31, 2023 13:05
@changeset-bot
Copy link

changeset-bot bot commented Mar 31, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 53ac5c7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 31, 2023
delucis
delucis approved these changes Mar 31, 2023
View reviewed changes
Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Princesseuh Princesseuh merged commit 9cc7329 into main Mar 31, 2023
@Princesseuh Princesseuh deleted the fix/error-image-not-found branch March 31, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delucis delucis delucis approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Princesseuh @delucis