Fix InferGetStaticParamsType and InferGetStaticPropsType not working with sync getStaticPaths #6711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot working when getStaticPaths wasn't async
🦋 Changeset detectedLatest commit: 981774f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
1 task
bluwy
approved these changes
Mar 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
InferGetStaticParamsType and InferGetStaticPropsType always assumed that
getStaticPathswas async, but it can be sync in some cases. This PR fixes this.This PR additionally updates the JSDoc comments to show usage with
satisfies, as trying to typegetStaticPathsdirectly will cause InferGetStaticParamsType and InferGetStaticPropsType to not work (since they work by inferring the return value, which the type will overwrite.satisfiesis great)Testing
Tested manually
Docs
N/A