Fix: Paginate adds unexpected trailing slash on index route #6676
Conversation
🦋 Changeset detectedLatest commit: b7a4051 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
Will resolve that failed unit test tomorrow! Looks like we expect a |
bholmesdev
force-pushed
the
fix/paginate-build-format-file
branch
from
8228394
to
56099c1
Compare
| if (color === 'blue' && p === 1) { | ||
| expect(prevHref).to.be.undefined; | ||
| expect(nextHref).to.equal('/posts/blue/2'); | ||
| } | ||
| if (color === 'blue' && p === 2) { | ||
| expect(prevHref).to.equal('/posts/blue/1'); | ||
| expect(nextHref).to.be.undefined; |
There was a problem hiding this comment.
Do these tests every run? Say when p = '1' ===> p === 1 is false which will cause the test to not run
There was a problem hiding this comment.
Sorry, this is a super imperative way to check if the params entry matches one of the items in the list (see the lines just above). Brain-dead solution I know, but oddly the simplest I could find 😅
There was a problem hiding this comment.
I meant that p is always a string so comparing it to the numbers will return false
'1' !=== 1
I'm I overlooking something?
There was a problem hiding this comment.
Ohhhh right you are! I'm a fool. Will fix
Co-authored-by: Happydev <81974850+MoustaphaDev@users.noreply.github.com>
…/astro into fix/paginate-build-format-file
Changes
paginatecreate brokenpage.url.prevlink for second page (added trailing slash) #6603undefinedfor index routes during pagination. Otherwise, this inserts an expected trailing/. found this also generates/posts//by default!Testing
Docs
N/A