Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix head injection in body with slots.render() and head buffering #6216

Merged
merged 3 commits into from
Feb 13, 2023

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Feb 10, 2023

Changes

Testing

  • New test case added

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2023

🦋 Changeset detected

Latest commit: fb6d334

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 10, 2023
@matthewp
Copy link
Contributor Author

!preview headbody

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 10, 2023
@github-actions
Copy link
Contributor

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--headbody" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --output-logs=new-only --no-deps --filter=astro --filter=create-astro --filter="@astrojs/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/image, @astrojs/lit, @astrojs/markdown-component, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/turbolinks, @astrojs/vercel, @astrojs/vue, @astrojs/webapi, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote computation caching enabled (experimental)�[0m �[35m@astrojs/webapi:build: �[0mcache hit, suppressing output �[2m668f327ac2c8d510�[0m �[34mcreate-astro:build: �[0mcache hit, suppressing output �[2m47e335a14ed2c3ad�[0m �[33m@astrojs/prism:build: �[0mcache hit, suppressing output �[2mc9cb5a90e84fe5c7�[0m �[36m@astrojs/telemetry:build: �[0mcache hit, suppressing output �[2medf67dad337149c7�[0m �[35m@astrojs/markdown-remark:build: �[0mcache hit, suppressing output �[2m9e4846e30ecae1a9�[0m �[32mastro:build: �[0mcache miss, executing �[2m617fe96a5c9dd310�[0m �[32mastro:build: �[0m �[32mastro:build: �[0m> astro@0.0.0-headbody-20230210211128 build /home/runner/work/astro/astro/packages/astro �[32mastro:build: �[0m> pnpm run prebuild && astro-scripts build "src/**/*.ts" && tsc �[32mastro:build: �[0m �[32mastro:build: �[0m �[32mastro:build: �[0m> astro@0.0.0-headbody-20230210211128 prebuild /home/runner/work/astro/astro/packages/astro �[32mastro:build: �[0m> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" �[32mastro:build: �[0m �[36m@astrojs/react:build: �[0mcache miss, executing �[2m411639381f6d4273�[0m �[35m@astrojs/image:build: �[0mcache miss, executing �[2mdff345b708fce55e�[0m �[32m@astrojs/cloudflare:build: �[0mcache miss, executing �[2m589b0423cf3fd210�[0m �[34m@astrojs/node:build: �[0mcache miss, executing �[2m574a875202452d75�[0m �[35m@astrojs/alpinejs:build: �[0mcache miss, executing �[2m42dd953b46a15384�[0m �[33m@astrojs/solid-js:build: �[0mcache miss, executing �[2mac58c34f2828d197�[0m �[33m@astrojs/vue:build: �[0mcache miss, executing �[2m66ffa0da27b838a5�[0m �[36m@astrojs/rss:build: �[0mcache miss, executing �[2m7df14dcf4bda9f0f�[0m �[34m@astrojs/mdx:build: �[0mcache miss, executing �[2m4d010c541a08735a�[0m �[32m@astrojs/preact:build: �[0mcache miss, executing �[2m2ce0fbf473f82cfc�[0m �[35m@astrojs/image:build: �[0m �[35m@astrojs/image:build: �[0m> @astrojs/image@0.14.1 build /home/runner/work/astro/astro/packages/integrations/image �[35m@astrojs/image:build: �[0m> astro-scripts build "src/**/*.ts" && tsc && pnpm run postbuild �[35m@astrojs/image:build: �[0m �[36m@astrojs/react:build: �[0m �[36m@astrojs/react:build: �[0m> @astrojs/react@2.0.2 build /home/runner/work/astro/astro/packages/integrations/react �[36m@astrojs/react:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/react:build: �[0m �[34m@astrojs/node:build: �[0m �[34m@astrojs/node:build: �[0m> @astrojs/node@5.0.3 build /home/runner/work/astro/astro/packages/integrations/node �[34m@astrojs/node:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/node:build: �[0m �[32m@astrojs/cloudflare:build: �[0m �[32m@astrojs/cloudflare:build: �[0m> @astrojs/cloudflare@6.1.2 build /home/runner/work/astro/astro/packages/integrations/cloudflare �[32m@astrojs/cloudflare:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/cloudflare:build: �[0m �[33m@astrojs/vue:build: �[0m �[33m@astrojs/vue:build: �[0m> @astrojs/vue@2.0.1 build /home/runner/work/astro/astro/packages/integrations/vue �[33m@astrojs/vue:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[33m@astrojs/vue:build: �[0m �[35m@astrojs/alpinejs:build: �[0m �[35m@astrojs/alpinejs:build: �[0m> @astrojs/alpinejs@0.1.3 build /home/runner/work/astro/astro/packages/integrations/alpinejs �[35m@astrojs/alpinejs:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/alpinejs:build: �[0m �[36m@astrojs/rss:build: �[0m �[36m@astrojs/rss:build: �[0m> @astrojs/rss@2.1.0 build /home/runner/work/astro/astro/packages/astro-rss �[36m@astrojs/rss:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/rss:build: �[0m �[33m@astrojs/solid-js:build: �[0m �[33m@astrojs/solid-js:build: �[0m> @astrojs/solid-js@2.0.2 build /home/runner/work/astro/astro/packages/integrations/solid �[33m@astrojs/solid-js:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/solid-js:build: �[0m �[34m@astrojs/mdx:build: �[0m �[34m@astrojs/mdx:build: �[0m> @astrojs/mdx@0.16.0 build /home/runner/work/astro/astro/packages/integrations/mdx �[34m@astrojs/mdx:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/mdx:build: �[0m �[32m@astrojs/preact:build: �[0m �[32m@astrojs/preact:build: �[0m> @astrojs/preact@2.0.2 build /home/runner/work/astro/astro/packages/integrations/preact �[32m@astrojs/preact:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/preact:build: �[0m �[34m@astrojs/netlify:build: �[0mcache miss, executing �[2mbf9a8a09b236100e�[0m �[33m@astrojs/partytown:build: �[0mcache miss, executing �[2mf601ea0e78346461�[0m �[36m@astrojs/vercel:build: �[0mcache miss, executing �[2m45358be14c8135e0�[0m �[35m@astrojs/deno:build: �[0mcache miss, executing �[2ma370fd8cddd99417�[0m �[33m@astrojs/partytown:build: �[0m �[33m@astrojs/partytown:build: �[0m> @astrojs/partytown@1.0.3 build /home/runner/work/astro/astro/packages/integrations/partytown �[33m@astrojs/partytown:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/partytown:build: �[0m �[32m@astrojs/tailwind:build: �[0mcache miss, executing �[2m0c4dcad08dea98c9�[0m �[33m@astrojs/sitemap:build: �[0mcache miss, executing �[2m7c8781bffd8cfc3e�[0m �[34m@astrojs/netlify:build: �[0m �[34m@astrojs/netlify:build: �[0m> @astrojs/netlify@2.1.2 build /home/runner/work/astro/astro/packages/integrations/netlify �[34m@astrojs/netlify:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/netlify:build: �[0m �[36m@astrojs/vercel:build: �[0m �[36m@astrojs/vercel:build: �[0m> @astrojs/vercel@3.1.1 build /home/runner/work/astro/astro/packages/integrations/vercel �[36m@astrojs/vercel:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/vercel:build: �[0m �[34m@astrojs/prefetch:build: �[0mcache miss, executing �[2m824037fd32efed89�[0m �[36m@astrojs/svelte:build: �[0mcache miss, executing �[2m961b57612d8c12d7�[0m �[35m@astrojs/lit:build: �[0mcache miss, executing �[2mf7008142a7585f5b�[0m �[35m@astrojs/deno:build: �[0m �[35m@astrojs/deno:build: �[0m> @astrojs/deno@4.0.0 build /home/runner/work/astro/astro/packages/integrations/deno �[35m@astrojs/deno:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/deno:build: �[0m �[33m@astrojs/sitemap:build: �[0m �[33m@astrojs/sitemap:build: �[0m> @astrojs/sitemap@1.0.1 build /home/runner/work/astro/astro/packages/integrations/sitemap �[33m@astrojs/sitemap:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/sitemap:build: �[0m �[36m@astrojs/svelte:build: �[0m �[36m@astrojs/svelte:build: �[0m> @astrojs/svelte@2.0.1 build /home/runner/work/astro/astro/packages/integrations/svelte �[36m@astrojs/svelte:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[36m@astrojs/svelte:build: �[0m �[32m@astrojs/tailwind:build: �[0m �[32m@astrojs/tailwind:build: �[0m> @astrojs/tailwind@3.0.1 build /home/runner/work/astro/astro/packages/integrations/tailwind �[32m@astrojs/tailwind:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/tailwind:build: �[0m �[34m@astrojs/prefetch:build: �[0m �[34m@astrojs/prefetch:build: �[0m> @astrojs/prefetch@0.1.2 build /home/runner/work/astro/astro/packages/integrations/prefetch �[34m@astrojs/prefetch:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/prefetch:build: �[0m �[35m@astrojs/lit:build: �[0m �[35m@astrojs/lit:build: �[0m> @astrojs/lit@1.2.0 build /home/runner/work/astro/astro/packages/integrations/lit �[35m@astrojs/lit:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/lit:build: �[0m �[35m@astrojs/image:build: �[0m �[35m@astrojs/image:build: �[0m> @astrojs/image@0.14.1 postbuild /home/runner/work/astro/astro/packages/integrations/image �[35m@astrojs/image:build: �[0m> astro-scripts copy "src/**/*.wasm" �[35m@astrojs/image:build: �[0m �[33m@astrojs/turbolinks:build: �[0mcache miss, executing �[2ma0701e2c046837b3�[0m �[33m@astrojs/turbolinks:build: �[0m �[33m@astrojs/turbolinks:build: �[0m> @astrojs/turbolinks@0.1.5 build /home/runner/work/astro/astro/packages/integrations/turbolinks �[33m@astrojs/turbolinks:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/turbolinks:build: �[0m Tasks: 26 successful, 26 total Cached: 5 cached, 26 total Time: 1m3.676s Package �[36m"@astrojs/markdown-remark"�[39m must depend on the current version of �[36m"astro"�[39m: �[32m"0.0.0-headbody-20230210211128"�[39m vs �[31m"^2.0.2"�[39m 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--headbody tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/image 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/turbolinks 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/markdown-component 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/webapi 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-headbody-20230210211128) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 2.1.0 is already published on npm 🦋 �[33mwarn�[39m create-astro is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.1.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/cloudflare is not being published because version 6.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 4.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/image is not being published because version 0.14.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 1.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 0.16.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 2.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 5.0.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 1.0.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 1.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/turbolinks is not being published because version 0.1.5 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 3.1.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-component is not being published because version 1.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/webapi is not being published because version 2.0.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-headbody-20230210211128"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-headbody-20230210211128 🦋 Creating git tag... 🦋 New tag: astro@0.0.0-headbody-20230210211128

@matthewp
Copy link
Contributor Author

!preview

@github-actions
Copy link
Contributor

Invalid comment format. Expected: "!preview "

@matthewp
Copy link
Contributor Author

!preview headbody

@github-actions
Copy link
Contributor

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--headbody" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --output-logs=new-only --no-deps --filter=astro --filter=create-astro --filter="@astrojs/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/image, @astrojs/lit, @astrojs/markdown-component, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/turbolinks, @astrojs/vercel, @astrojs/vue, @astrojs/webapi, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 27 packages�[0m �[2m• Remote computation caching enabled (experimental)�[0m �[35m@astrojs/webapi:build: �[0mcache hit, suppressing output �[2m668f327ac2c8d510�[0m �[34mcreate-astro:build: �[0mcache hit, suppressing output �[2m47e335a14ed2c3ad�[0m �[36m@astrojs/prism:build: �[0mcache hit, suppressing output �[2mc9cb5a90e84fe5c7�[0m �[33m@astrojs/telemetry:build: �[0mcache hit, suppressing output �[2medf67dad337149c7�[0m �[35m@astrojs/markdown-remark:build: �[0mcache hit, suppressing output �[2m9e4846e30ecae1a9�[0m �[32mastro:build: �[0mcache miss, executing �[2m03f1aa98582af937�[0m �[32mastro:build: �[0m �[32mastro:build: �[0m> astro@0.0.0-headbody-20230210211734 build /home/runner/work/astro/astro/packages/astro �[32mastro:build: �[0m> pnpm run prebuild && astro-scripts build "src/**/*.ts" && tsc �[32mastro:build: �[0m �[32mastro:build: �[0m �[32mastro:build: �[0m> astro@0.0.0-headbody-20230210211734 prebuild /home/runner/work/astro/astro/packages/astro �[32mastro:build: �[0m> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" �[32mastro:build: �[0m �[32m@astrojs/rss:build: �[0mcache miss, executing �[2m9b77f456ccd07706�[0m �[35m@astrojs/lit:build: �[0mcache miss, executing �[2mf49cacca9efe58c1�[0m �[36m@astrojs/vercel:build: �[0mcache miss, executing �[2md8aa44918530b028�[0m �[32m@astrojs/vue:build: �[0mcache miss, executing �[2m026a13f296b4e460�[0m �[33m@astrojs/solid-js:build: �[0mcache miss, executing �[2mc5bf7bf3faafa91d�[0m �[34m@astrojs/mdx:build: �[0mcache miss, executing �[2mac92b310d8927c88�[0m �[34m@astrojs/react:build: �[0mcache miss, executing �[2m77d36ccf821c5489�[0m �[36m@astrojs/preact:build: �[0mcache miss, executing �[2mfcc8e5b1739d8634�[0m �[33m@astrojs/node:build: �[0mcache miss, executing �[2mb811c386ea1d8b10�[0m �[35m@astrojs/deno:build: �[0mcache miss, executing �[2m0ff0213034394684�[0m �[32m@astrojs/rss:build: �[0m �[32m@astrojs/rss:build: �[0m> @astrojs/rss@2.1.0 build /home/runner/work/astro/astro/packages/astro-rss �[32m@astrojs/rss:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/rss:build: �[0m �[33m@astrojs/solid-js:build: �[0m �[33m@astrojs/solid-js:build: �[0m> @astrojs/solid-js@2.0.2 build /home/runner/work/astro/astro/packages/integrations/solid �[33m@astrojs/solid-js:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/solid-js:build: �[0m �[35m@astrojs/lit:build: �[0m �[35m@astrojs/lit:build: �[0m> @astrojs/lit@1.2.0 build /home/runner/work/astro/astro/packages/integrations/lit �[35m@astrojs/lit:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/lit:build: �[0m �[33m@astrojs/node:build: �[0m �[33m@astrojs/node:build: �[0m> @astrojs/node@5.0.3 build /home/runner/work/astro/astro/packages/integrations/node �[33m@astrojs/node:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/node:build: �[0m �[34m@astrojs/mdx:build: �[0m �[34m@astrojs/mdx:build: �[0m> @astrojs/mdx@0.16.0 build /home/runner/work/astro/astro/packages/integrations/mdx �[34m@astrojs/mdx:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/mdx:build: �[0m �[32m@astrojs/vue:build: �[0m �[32m@astrojs/vue:build: �[0m> @astrojs/vue@2.0.1 build /home/runner/work/astro/astro/packages/integrations/vue �[32m@astrojs/vue:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[32m@astrojs/vue:build: �[0m �[36m@astrojs/preact:build: �[0m �[36m@astrojs/preact:build: �[0m> @astrojs/preact@2.0.2 build /home/runner/work/astro/astro/packages/integrations/preact �[36m@astrojs/preact:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/preact:build: �[0m �[36m@astrojs/vercel:build: �[0m �[36m@astrojs/vercel:build: �[0m> @astrojs/vercel@3.1.1 build /home/runner/work/astro/astro/packages/integrations/vercel �[36m@astrojs/vercel:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/vercel:build: �[0m �[34m@astrojs/react:build: �[0m �[34m@astrojs/react:build: �[0m> @astrojs/react@2.0.2 build /home/runner/work/astro/astro/packages/integrations/react �[34m@astrojs/react:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/react:build: �[0m �[35m@astrojs/deno:build: �[0m �[35m@astrojs/deno:build: �[0m> @astrojs/deno@4.0.0 build /home/runner/work/astro/astro/packages/integrations/deno �[35m@astrojs/deno:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/deno:build: �[0m �[33m@astrojs/alpinejs:build: �[0mcache miss, executing �[2m7b0841d718e34d84�[0m �[34m@astrojs/netlify:build: �[0mcache miss, executing �[2md2b53ec4a4b37e0b�[0m �[36m@astrojs/image:build: �[0mcache miss, executing �[2m45828baa8f7d9292�[0m �[35m@astrojs/turbolinks:build: �[0mcache miss, executing �[2m8bb3048b75e474ed�[0m �[33m@astrojs/prefetch:build: �[0mcache miss, executing �[2m0930004122e1d387�[0m �[32m@astrojs/partytown:build: �[0mcache miss, executing �[2maf3cfe9d6326001e�[0m �[33m@astrojs/alpinejs:build: �[0m �[33m@astrojs/alpinejs:build: �[0m> @astrojs/alpinejs@0.1.3 build /home/runner/work/astro/astro/packages/integrations/alpinejs �[33m@astrojs/alpinejs:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/alpinejs:build: �[0m �[36m@astrojs/tailwind:build: �[0mcache miss, executing �[2m3369c8e6b3bab31e�[0m �[35m@astrojs/cloudflare:build: �[0mcache miss, executing �[2m9588d9f3524916d8�[0m �[32m@astrojs/svelte:build: �[0mcache miss, executing �[2m481711540b50df4b�[0m �[33m@astrojs/sitemap:build: �[0mcache miss, executing �[2mcc3b5158f88a5223�[0m �[34m@astrojs/netlify:build: �[0m �[34m@astrojs/netlify:build: �[0m> @astrojs/netlify@2.1.2 build /home/runner/work/astro/astro/packages/integrations/netlify �[34m@astrojs/netlify:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/netlify:build: �[0m �[36m@astrojs/image:build: �[0m �[36m@astrojs/image:build: �[0m> @astrojs/image@0.14.1 build /home/runner/work/astro/astro/packages/integrations/image �[36m@astrojs/image:build: �[0m> astro-scripts build "src/**/*.ts" && tsc && pnpm run postbuild �[36m@astrojs/image:build: �[0m �[35m@astrojs/turbolinks:build: �[0m �[35m@astrojs/turbolinks:build: �[0m> @astrojs/turbolinks@0.1.5 build /home/runner/work/astro/astro/packages/integrations/turbolinks �[35m@astrojs/turbolinks:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/turbolinks:build: �[0m �[32m@astrojs/partytown:build: �[0m �[32m@astrojs/partytown:build: �[0m> @astrojs/partytown@1.0.3 build /home/runner/work/astro/astro/packages/integrations/partytown �[32m@astrojs/partytown:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/partytown:build: �[0m �[33m@astrojs/prefetch:build: �[0m �[33m@astrojs/prefetch:build: �[0m> @astrojs/prefetch@0.1.2 build /home/runner/work/astro/astro/packages/integrations/prefetch �[33m@astrojs/prefetch:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/prefetch:build: �[0m �[35m@astrojs/cloudflare:build: �[0m �[35m@astrojs/cloudflare:build: �[0m> @astrojs/cloudflare@6.1.2 build /home/runner/work/astro/astro/packages/integrations/cloudflare �[35m@astrojs/cloudflare:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/cloudflare:build: �[0m �[32m@astrojs/svelte:build: �[0m �[32m@astrojs/svelte:build: �[0m> @astrojs/svelte@2.0.1 build /home/runner/work/astro/astro/packages/integrations/svelte �[32m@astrojs/svelte:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[32m@astrojs/svelte:build: �[0m �[33m@astrojs/sitemap:build: �[0m �[33m@astrojs/sitemap:build: �[0m> @astrojs/sitemap@1.0.1 build /home/runner/work/astro/astro/packages/integrations/sitemap �[33m@astrojs/sitemap:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/sitemap:build: �[0m �[36m@astrojs/tailwind:build: �[0m �[36m@astrojs/tailwind:build: �[0m> @astrojs/tailwind@3.0.1 build /home/runner/work/astro/astro/packages/integrations/tailwind �[36m@astrojs/tailwind:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/tailwind:build: �[0m �[36m@astrojs/image:build: �[0m �[36m@astrojs/image:build: �[0m> @astrojs/image@0.14.1 postbuild /home/runner/work/astro/astro/packages/integrations/image �[36m@astrojs/image:build: �[0m> astro-scripts copy "src/**/*.wasm" �[36m@astrojs/image:build: �[0m Tasks: 26 successful, 26 total Cached: 5 cached, 26 total Time: 1m7.365s Package �[36m"@astrojs/markdown-remark"�[39m must depend on the current version of �[36m"astro"�[39m: �[32m"0.0.0-headbody-20230210211734"�[39m vs �[31m"^2.0.2"�[39m 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--headbody tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/image 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/turbolinks 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/markdown-component 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/webapi 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-headbody-20230210211734) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 2.1.0 is already published on npm 🦋 �[33mwarn�[39m create-astro is not being published because version 3.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.1.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/cloudflare is not being published because version 6.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 4.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/image is not being published because version 0.14.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 1.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 0.16.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 2.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 5.0.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 1.0.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 1.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 3.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/turbolinks is not being published because version 0.1.5 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 3.1.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-component is not being published because version 1.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 2.0.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 2.0.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/webapi is not being published because version 2.0.0 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-headbody-20230210211734"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-headbody-20230210211734 🦋 Creating git tag... 🦋 New tag: astro@0.0.0-headbody-20230210211734

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feeling some deja vu, but gotta slot in more test cases sometimes

---

<SlotRenderComponent>
<p slot="slot-name">Paragraph.</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see an assertion that this ever ends up in the DOM anywhere. (That may be OK for this; I'm just calling it out in case it's an accidental omission.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That part doesn't matter here. The slots just exist to create the condition where head was inserted improperly. So we only need to test that the links were injected in the head and not the body.

@matthewp matthewp merged commit 79783fc into main Feb 13, 2023
@matthewp matthewp deleted the headbody2 branch February 13, 2023 12:49
@astrobot-houston astrobot-houston mentioned this pull request Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
3 participants