Fix hoisted script propagation in content collection pages #6119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9df9d3a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
natemoo-re
approved these changes
Feb 3, 2023
bholmesdev
reviewed
Feb 3, 2023
| @@ -22,6 +22,7 @@ export interface PageBuildData { | |||
| moduleSpecifier: string; | |||
| css: Map<string, { depth: number; order: number }>; | |||
| contentCollectionCss: Map<string, Set<string>>; | |||
There was a problem hiding this comment.
nit: Meant to rename contentCollectionCss to propagatedCss or propagatedStyles for consistency. Possible to add to this PR?
Comment on lines
43
to
46
| ctx: { getModuleInfo: GetModuleInfo }, | ||
| walkUntil?: (importer: string) => boolean | ||
| ): Generator<[ModuleInfo, number, number], void, unknown> { | ||
| for (const res of walkParentInfos(id, ctx)) { | ||
| for (const res of walkParentInfos(id, ctx, walkUntil)) { |
There was a problem hiding this comment.
This refactor is unused looks like. Good to revert changes to this file!
| ); | ||
| } | ||
| if (entryScripts.size) { | ||
| const entryFileNames = new Set<string>(); |
There was a problem hiding this comment.
Love that we can look these up now 👏 Way simpler than scary naming conventions!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Docs
N/A