[Lit] Fix hydration not having the same reactive values as server #6080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f3530b2 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
e111077
force-pushed
the
fix-lit-hydration
branch
from
b760e74
to
70e8f45
Compare
e111077
changed the title
matthewp
reviewed
Jan 31, 2023
matthewp
reviewed
Feb 1, 2023
| const isReactiveProperty = name in Ctr.prototype; | ||
| const isReflectedReactiveProperty = Ctr.elementProperties.get(name)?.reflect; | ||
|
|
||
| // Only defer hydration if we are setting a reactive property that cannot |
matthewp
reviewed
Feb 1, 2023
|
|
||
| // Only defer hydration if we are setting a reactive property that cannot | ||
| // be reflected / serialized as a property. | ||
| shouldDeferHydration ||= isReactiveProperty && !isReflectedReactiveProperty; |
There was a problem hiding this comment.
I think you might be the first to add logical or assignments to our codebase.
matthewp
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5777
Changes
clientEntrypointto Lit that sets props on the clientdefer-hydrationattribute to defer hydration until we have set props on clientTesting
Changed the props to be different from default value in the e2e test
Docs
This is a bugfix. Makes Lit integration work as intended.