Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required alt to Picture example #6074

Merged
merged 2 commits into from
Feb 1, 2023
Merged

Add required alt to Picture example #6074

merged 2 commits into from
Feb 1, 2023

Conversation

BryceRussell
Copy link
Member

Changes

Add required alt prop to <Picture> example

Docs for alt

Testing

No tests, change to docs

Docs

/cc @withastro/maintainers-docs for feedback!

Update example with required prop

@BryceRussell BryceRussell requested a review from a team as a code owner January 31, 2023 18:35
@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: c240191

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jan 31, 2023
sarah11918
sarah11918 approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @BryceRussell! 🚀

@sarah11918 sarah11918 merged commit e3e2498 into withastro:main Feb 1, 2023
@BryceRussell BryceRussell deleted the fix-picture-example branch February 1, 2023 01:29
matthewp pushed a commit that referenced this pull request Feb 3, 2023
@BryceRussell @matthewp
Add required alt to Picture example (#6074)
4f5b224 
Co-authored-by: BryceRussell <19967622+BryceRussell@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BryceRussell @sarah11918