Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CHANGELOGs #5951

Merged
merged 27 commits into from
Jan 24, 2023
Merged

Improve CHANGELOGs #5951

merged 27 commits into from
Jan 24, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented Jan 24, 2023 •
edited
Loading

Changes

  • Edits CHANGELOGs for

    • astro
    • mdx
    • deno
    • image
    • netlify
    • markdown/remark
    • astro-prism
    • astro-rss
    • create-astro
    • cloudflare
    • lit
    • node
    • partytown
    • preact
    • react
    • solid
    • svelte
    • tailwind
    • vercel
    • vue
    • telemetry
    • webapi
    • scripts

  • Collapses all beta changelogs with <details> elements

  • Reworks some notes that contradicted or repeated each other

  • Designed to be merged into [ci] release #5948 before release

Testing

n/a

Docs

/cc @withastro/maintainers-docs for feedback!

@changeset-bot
Copy link

changeset-bot bot commented Jan 24, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4138675

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 24, 2023
@delucis delucis self-assigned this Jan 24, 2023
@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Jan 24, 2023
@github-actions github-actions bot added the feat: markdown Related to Markdown (scope) label Jan 24, 2023
@github-actions github-actions bot added the pkg: create-astro Related to the `create-astro` package (scope) label Jan 24, 2023
@github-actions github-actions bot added the pkg: lit Related to Lit (scope) label Jan 24, 2023
@github-actions github-actions bot added the pkg: preact Related to Preact (scope) label Jan 24, 2023
@github-actions github-actions bot added the pkg: react Related to React (scope) label Jan 24, 2023
@github-actions github-actions bot added the pkg: solid Related to Solid (scope) label Jan 24, 2023
@github-actions github-actions bot added the pkg: svelte Related to Svelte (scope) label Jan 24, 2023
@github-actions github-actions bot added the pkg: vue Related to Vue (scope) label Jan 24, 2023
@delucis delucis marked this pull request as ready for review January 24, 2023 12:01
bholmesdev
bholmesdev reviewed Jan 24, 2023
View reviewed changes
Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some heading commits. Refactor really brings our changes where they belog

packages/integrations/mdx/CHANGELOG.md Outdated Show resolved Hide resolved
packages/integrations/mdx/CHANGELOG.md Outdated Show resolved Hide resolved
packages/markdown/remark/CHANGELOG.md Outdated Show resolved Hide resolved
@delucis @bholmesdev
Reinstate h3s for headings
84026a2 
Co-authored-by: Ben Holmes <hey@bholmes.dev>
sarah11918
sarah11918 approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chris' clearly NOT confusing, cumbersome, complicated to use changelogs! 🥳

@aFuzzyBear
Copy link
Contributor

Looks fantastic, =)

natemoo-re
natemoo-re approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! This is so much cleaner to scan through!

@delucis delucis merged commit 26cbfa5 into changeset-release/main Jan 24, 2023
@delucis delucis deleted the chris/2.0-changelogs branch January 24, 2023 14:04
@matthewp matthewp restored the chris/2.0-changelogs branch January 24, 2023 16:00
@delucis delucis deleted the chris/2.0-changelogs branch January 31, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bholmesdev bholmesdev bholmesdev left review comments

@matthewp matthewp matthewp approved these changes

@sarah11918 sarah11918 sarah11918 approved these changes

@natemoo-re natemoo-re natemoo-re approved these changes

Assignees

@delucis delucis

Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@delucis @aFuzzyBear @matthewp @sarah11918 @natemoo-re @bholmesdev