Refactor Svelte preprocess integration handling #5901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 47be52c The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
1 task
matthewp
approved these changes
Jan 19, 2023
matthewp
dismissed
github-actions[bot]’s stale review
Going out with the next major
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #5899
The Svelte integration beta uses
vitePreprocessto preprocess files, this will cause users that migrate (especially those installed hoisted like npm) to lose VSCode intellisense in Svelte files.This PR add this migration guide, and changes the fallback preprocess logic to prevent
vitePreprocessadded twice, which might be wasteful (NOTE: Double preprocessing was an issue for pnpm users before)Testing
Tested manually for the
astro add svelte tailwindcommand in the examples which still work.The existing test should pass as they're not affected by the breaking change.
Docs
I've updated the Svelte integration README for information of getting intellisense to work too.