Support rendering @motionone/solid components
#5233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2bc94c8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
commented
Oct 28, 2022
Comment on lines
+136
to
+143
| let isTagged = false; | ||
| try { | ||
| isTagged = Component && (Component as any)[Renderer]; | ||
| } catch { | ||
| // Accessing `Component[Renderer]` may throw if `Component` is a Proxy that doesn't | ||
| // return the actual read-only value. In this case, ignore. | ||
| } | ||
| if (isTagged) { |
There was a problem hiding this comment.
The error would be something like:
error 'get' on proxy: property 'Symbol(astro:renderer)' is a read-only and non-configurable data property on the proxy target but the proxy did not return its actual value (expected '@astrojs/solid-js' but got 'props => {
delete props.tag;
return __vite_ssr_import_1__.createComponent(BaseComponent, __vite_ssr_imp...<omitted>... }')
There was a problem hiding this comment.
It would be very cheeky to parse the error message to get it's actual value now that I think of it, but right now it works without doing so.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fix #4652
@motionone/solidcomponents export a proxy component forMotion, so when you doMotion.div, it renders adivdynamically. The proxy captures the"div"(or anything) dynamically to render the right HTML element.This brings many issues for Astro:
await Motionreturnsundefined, because it's akin toMotion.thenand there's no promise to resolve.Motion[Symbol.for('astro:renderer)]throws because the Proxy doesn't return the right value.Motion.isAstroComponentFactoryis truthy because it returns a Solid component.This PR handles these 3 edge cases to properly handle it. Another solution is to not have
Motionwrap a Proxy, and follow styled-components' method of a hardcoded list of dom elements.Testing
Added test to
solid-componentDocs
N/A. bug fix.