Fix CSS ordering between imported and Astro styles #4907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d4b6ecc The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
jasikpark
reviewed
Sep 28, 2022
tony-sull
reviewed
Sep 28, 2022
| </style> | ||
| ``` | ||
|
|
||
| The `<style>` defined in this component will be placed *below* the imported CSS. When compiled for production this will result in something like this: |
There was a problem hiding this comment.
Just to double check here, these will both be added after any user provided <link rel="stylesheet"> in the head, right? Meaning any stylesheets pulled from /public or an external CDN would be first on page?
There was a problem hiding this comment.
Yes, all of the CSS and scripts we add are added to the bottom of the head, so after all user-defined head content. We don't parse the HTML so we don't even know about your link tags.
matthewp
dismissed
github-actions[bot]’s stale review
Tomorrow is release day
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The Astro styles should be placed after the imported styles, so that they are preferred if their specificity is the same.
Testing
Docs
N/A, bug fix