Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VS Code extension #467

Merged
merged 9 commits into from
Jun 16, 2021
Merged

Fix VS Code extension #467

merged 9 commits into from
Jun 16, 2021

Conversation

natemoo-re
Copy link
Member

Changes

These are a number of changes which fix the VS Code extension! The diff is mostly noisy renames, but I tracked it down to one main problem.

We need to use npm@6 and run npm install inside of tools/vscode before publishing. This ensures that the dependencies inside of node_modules are packaged with the extension

Testing

vsce package inside of tools/vscode is great for testing the final output. You can right-click on the generated output file and click "Install Extension VSIX" to install the local extension version.

Docs

Bug fix!

@natemoo-re natemoo-re requested a review from a team as a code owner June 16, 2021 18:19
@changeset-bot
Copy link

changeset-bot bot commented Jun 16, 2021

⚠️ No Changeset found

Latest commit: 9023cfb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jun 16, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/astro-www/A2D55aFKTkWcyYyJTyUE8AsPTf9E
✅ Preview: https://astro-www-git-fix-vscode-2-pikapkg.vercel.app

@natemoo-re natemoo-re merged commit 0dd2788 into main Jun 16, 2021
@natemoo-re natemoo-re deleted the fix/vscode-2 branch June 16, 2021 18:20
@natemoo-re natemoo-re mentioned this pull request Jun 16, 2021
Closed
@natemoo-re natemoo-re linked an issue Jun 16, 2021 that may be closed by this pull request
VSCode Language Support Extension looks for parser directory that doesn't exist #373
Closed
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@natemoo-re
Fix VS Code extension (withastro#467)
9dc84ea 
* chore: astro-languageserver => @astrojs/language-server

* chore: astro-vscode => vscode

* chore: move devDeps to deps

* chore: bump language-server to 0.5.0-next.0

* chore: remove astro-docs

* chore: update changelog

* fix: expose `astro-ls` bin

* fix: vscode extension

* chore: update changelog
ematipico pushed a commit that referenced this pull request Feb 7, 2025
@renovate
fix(deps): update dependency @astrojs/solid-js to v5 (#467)
decacaa 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VSCode Language Support Extension looks for parser directory that doesn't exist
1 participant
@natemoo-re