Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor runtime #4201

Merged
merged 4 commits into from
Aug 8, 2022
Merged

Refactor runtime #4201

merged 4 commits into from
Aug 8, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Aug 8, 2022

Changes

  • This refactors runtime/server/index.ts to split it apart, to rendering (most of the code) and stuff for the Astro global and some utilities, all into their own separate files. Even among rendering it's divided between code specifically for rendering pages vs. code that's for rendering Astro vs framework components.
  • Also adds a warning when attempting to use a client directive on an Astro component.
  • Closes 🐛 No good error message when adding a client directive to an Astro component #4090

Testing

  • Existing tests should pass

Docs

N/A

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 8, 2022
@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2022

🦋 Changeset detected

Latest commit: d71d81b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice organization! Thanks for doing this!

@matthewp matthewp merged commit 25d36d9 into main Aug 8, 2022
@matthewp matthewp deleted the better-astro-error-message branch August 8, 2022 19:35
@astrobot-houston astrobot-houston mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 No good error message when adding a client directive to an Astro component
2 participants