Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix client build sourcemap generation #4195

Merged
merged 7 commits into from
Aug 8, 2022
Merged

Fix client build sourcemap generation #4195

merged 7 commits into from
Aug 8, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Aug 8, 2022

Changes

Fixes #3970

  • Pass viteConfig.build config to client build Vite config
  • Fix sourcemap generation in astro:build and astro:vite-plugin-env plugins

Testing

Added new sourcemap fixture to astro/test. Might be useful in the future for more sourcemaps test.

Docs

This should work by default without docs.

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2022

🦋 Changeset detected

Latest commit: 8877438

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 8, 2022
@bluwy bluwy changed the title Fix client sourcemap Fix client build sourcemap generation Aug 8, 2022
@bluwy bluwy merged commit 28ab273 into main Aug 8, 2022
@bluwy bluwy deleted the fix-client-sourcemap branch August 8, 2022 13:55
@astrobot-houston astrobot-houston mentioned this pull request Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: vite.build.sourcemap does not generate sourcemaps for client-side components on build
2 participants