-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compiler version #4175
Update compiler version #4175
Conversation
🦋 Changeset detectedLatest commit: a16df37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -24,7 +24,7 @@ describe('Doctype', () => { | |||
expect(html).to.match(/^<!DOCTYPE html>/i); | |||
}); | |||
|
|||
it('Preserves user provided doctype', async () => { | |||
it.skip('Preserves user provided doctype', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meant to be skipped? If so, leave a comment so that future people don't think its a mistake. Otherwise, should be safe to remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM if tests pass
Tests are failing is a compiler regression. The compiler release contains a few things, one of them seems to have broken custom element tag names in nested expressions. Probably this one would be my guess: withastro/compiler@28d1d4d So will have to hold off on merging this until that is fixed. It was a minor release of the compiler so this regression won't affect users. Example of what is now failing.
|
Changes
Testing
Docs
N/A, bug fix