Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler version #4175

Merged
merged 7 commits into from
Aug 5, 2022
Merged

Update compiler version #4175

merged 7 commits into from
Aug 5, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Aug 5, 2022

Changes

Testing

  • Tests added in compiler

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2022

🦋 Changeset detected

Latest commit: a16df37

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 5, 2022
@@ -24,7 +24,7 @@ describe('Doctype', () => {
expect(html).to.match(/^<!DOCTYPE html>/i);
});

it('Preserves user provided doctype', async () => {
it.skip('Preserves user provided doctype', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to be skipped? If so, leave a comment so that future people don't think its a mistake. Otherwise, should be safe to remove.

Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass

@matthewp
Copy link
Contributor Author

matthewp commented Aug 5, 2022

Tests are failing is a compiler regression. The compiler release contains a few things, one of them seems to have broken custom element tag names in nested expressions.

Probably this one would be my guess: withastro/compiler@28d1d4d

So will have to hold off on merging this until that is fixed. It was a minor release of the compiler so this regression won't affect users.


Example of what is now failing.

{show && <client-only-element></client-only-element>}

@matthewp matthewp merged commit 69db029 into main Aug 5, 2022
@matthewp matthewp deleted the update-compiler-version branch August 5, 2022 21:41
@astrobot-houston astrobot-houston mentioned this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Astro basics example produces double DOCTYPES
2 participants