Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve style HMR #4125

Merged
merged 3 commits into from
Aug 3, 2022
Merged

Improve style HMR #4125

merged 3 commits into from
Aug 3, 2022

Conversation

natemoo-re
Copy link
Member

Changes

  • Removes full reloads when updating style block inside of .astro files
  • Avoids firing HMR events when a file is saved without changes.
  • Improves HMR logs

Testing

Covered by existing tests

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 2, 2022

🦋 Changeset detected

Latest commit: 7f1350e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 2, 2022
@natemoo-re natemoo-re self-assigned this Aug 3, 2022
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Happy to help test this as well if you'd feel more confident with some hands on experience. Otherwise, I'll be sure to give this a spin once it's released.

packages/astro/src/vite-plugin-astro/hmr.ts Show resolved Hide resolved
@natemoo-re natemoo-re merged commit 5f3b3b4 into main Aug 3, 2022
@natemoo-re natemoo-re deleted the feat/style-hmr branch August 3, 2022 19:03
@astrobot-houston astrobot-houston mentioned this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants