Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send body with HEAD and GET on node integration #4105

Merged

Conversation

dimitrov-adrian
Copy link
Contributor

Changes

  • With latest change astro always set body on node integration Request

Testing

With the default SSR it does not works and get error, after it works.

Error reported:

TypeError: Request with GET/HEAD method cannot have body.
    at new Request (node:internal/deps/undici/undici:5599:17)
    at createRequestFromNodeRequest (file:///Users/e01/Workspace/astro-ssr-demo/node_modules/astro/dist/core/app/node.js:11:16)
    at file:///Users/e01/Workspace/astro-ssr-demo/node_modules/astro/dist/core/app/node.js:40:60
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async handler (file:///Users/e01/Workspace/astro-ssr-demo/node_modules/@astrojs/node/dist/server.js:14:30)

Docs

@changeset-bot
Copy link

changeset-bot bot commented Jul 31, 2022

🦋 Changeset detected

Latest commit: 8ee7555

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
astro Patch
@e2e/astro-component Patch
@e2e/error-react-spectrum Patch
@e2e/error-sass Patch
@e2e/errors Patch
@e2e/lit-component Patch
@e2e/preact-component Patch
@e2e/react-component Patch
@e2e/solid-component Patch
@e2e/svelte-component Patch
@e2e/e2e-tailwindcss Patch
@e2e/ts-resolution Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jul 31, 2022
@dimitrov-adrian
Copy link
Contributor Author

Related issue: #4104

@JulianCataldo
Copy link

JulianCataldo commented Aug 1, 2022

I can relate the exact same issue here. I applyied your patch and seems to work now, thanks!

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Appreciate the fix.

@natemoo-re natemoo-re linked an issue Aug 1, 2022 that may be closed by this pull request
1 task
@natemoo-re
Copy link
Member

This is a critical one so I'm going to merge even with the unrelated failure.

@natemoo-re natemoo-re merged commit 9cc3a11 into withastro:main Aug 2, 2022
@astrobot-houston astrobot-houston mentioned this pull request Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Ssr build not usable with node adaptor ?
3 participants